Defer marking request as completed until response is complete#694
Open
annervisser wants to merge 1 commit intoCodeGenieApp:mainlinefrom
Open
Defer marking request as completed until response is complete#694annervisser wants to merge 1 commit intoCodeGenieApp:mainlinefrom
annervisser wants to merge 1 commit intoCodeGenieApp:mainlinefrom
Conversation
Marking the request as complete before the response is finished causes issues if the request is still being read to create the response. Fixes CodeGenieApp#693
Author
|
This fixes the issue when using async code in middleware, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #693
Description of changes:
Defer marking request as completed until response is complete
Marking the request as complete before the response is finished causes issues if the request is still being read to create the response.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.